[pull] master from DataDog:master#532
Merged
Merged
Conversation
* Add example_config to Integration and require changelog when it changes * Add changelog entry
…23656) * Derive repo identity from git remote instead of directory basename * Add changelog * Drop leading underscore from GIT_REMOTE_PATTERNS module constant * Consolidate URL-parsing tests into Repository identity tests * Keep GitHubManager pointed at DataDog regardless of origin Codex review on PR #23656 caught a regression: deriving the org from the git remote URL means fork users would have their GitHubManager target their fork's API (e.g. `alice/integrations-core`), where the PRs, release labels and validation comments don't live. Revert that piece: `GitHubManager.repo_id` is back to `f'DataDog/{full_name}'`. The worktree fix still stands because `full_name` itself is now derived from the origin URL, so worktrees and forks both resolve to the right repo name. `Repository.org` and `DEFAULT_ORG` are dropped since nothing else consumed them.
* Migrate validate jmx-metrics from datadog_checks_dev to ddev
* Add changelog
* Apply formatter
* Fix mypy union-attr errors in _duplicate_bean_check
* Pass 'all' sentinel to iter() so the no-arg and 'all' branches actually validate every JMX integration
An empty selection tuple makes IntegrationRegistry.__finalize_selection
fall back to its 'changed roots' path, which iterates zero (or only
changed) integrations instead of all of them. Use ('all',) so the
finalizer returns set(), producing the intended full iteration.
Add a parametrized regression test that creates three fake JMX checks
and asserts both 'ddev validate jmx-metrics' and
'ddev validate jmx-metrics all' validate all three.
* Update otel_host_metrics_dashboard.json Applies semantic_mode native because we strictly want this to include the OTel host metrics only. Also explicitly queries system metrics with and without otel prefixes for backwards compatibility. * fix formatting * Remove pause_auto_refresh from OTel host metrics dashboard The datadog-assets validate-dashboards schema rejects this property (Additional properties are not allowed). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )